Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Oct 7, 2025

Description

Fully removes MONGODB-CR.

Summary of Changes

  • Remove the type from AuthMechanism
Notes for Reviewers

What is the motivation for this change?

Release Highlight

MONGODB-CR AuthMechanism removed.

Attempting to use will still raise an error.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review October 7, 2025 19:01
@durran durran requested a review from a team as a code owner October 7, 2025 19:01
@durran durran changed the title feat(NODE-6473): remove MONGODB-CR auth feat(NODE-6473)!: remove MONGODB-CR auth Oct 7, 2025
@tadjik1 tadjik1 self-assigned this Oct 8, 2025
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 8, 2025
Copy link
Contributor

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @durran, everything looks good to me, I only want to clarify if I understood correctly your approach for this statement from the ticket:

If the driver exposes the authentication mechanism in a public API, then:
Deprecate MONGODB-CR and raise an error indicating to the user that MONGODB-CR is no longer supported in MongoDB 4.0 and subsequently the current driver version.

@tadjik1 tadjik1 added the Team Review Needs review from team label Oct 8, 2025
@durran
Copy link
Member Author

durran commented Oct 9, 2025

Thanks @durran, everything looks good to me, I only want to clarify if I understood correctly your approach for this statement from the ticket:

If the driver exposes the authentication mechanism in a public API, then:
Deprecate MONGODB-CR and raise an error indicating to the user that MONGODB-CR is no longer supported in MongoDB 4.0 and subsequently the current driver version.

We had already done that - so now we've just removed it from the public API (via AuthMechanism) and throw the common error for missing auth mech.

@tadjik1 tadjik1 merged commit 9a1bc65 into main Oct 10, 2025
25 of 27 checks passed
@tadjik1 tadjik1 deleted the NODE-6473 branch October 10, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants